Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Develop - DC01 left #13597

Merged
merged 1 commit into from
Jul 22, 2021
Merged

[Bug] Develop - DC01 left #13597

merged 1 commit into from
Jul 22, 2021

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Jul 19, 2021

Description

https://github.com/Xelus22/QMK-VIA-Hex-Develop/runs/3103052314?check_suite_focus=true#step:13:597
Issue due to automatic changes in #13471

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Fix DC01 Left compile issue

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 20, 2021 00:05
@drashna drashna merged commit 6e9f667 into qmk:develop Jul 22, 2021
@skullydazed
Copy link
Member

This reintroduced a data error:

☒ dc01/left: MATRIX_COLS is inconsistent with the size of MATRIX_COL_PINS: 6 != 21

How can we get MATRIX_COLS and MATRIX_COL_PINS into sync here?

@Xelus22
Copy link
Contributor Author

Xelus22 commented Jul 22, 2021

@yiancar would there be an easy solution?

cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 22, 2021
Merge remote-tracking branch 'qmk/develop' into develop
412e2ae 
* qmk/develop: (141 commits)
  Implement GPIO abstraction for atsam (qmk#13567)
  [Keyboard][Bug] Add timer_avr to includes for broken builds (qmk#13641)
  [Keyboard] adds new revision: dztech/dz60rgb/v2_1 (qmk#13636)
  [Keyboard] Fixing info.json for h0oni/hotduck (qmk#13640)
  [Keyboard] Ymd40v2new layouts and fixed per-switch backlight (qmk#13622)
  [Bug] Develop - DC01 left (qmk#13597)
  [Keyboard] Fix clawsome/hatchback and reviung5 compile issues (qmk#13607)
  [Keyboard] add ogurec (qmk#13242)
  [Keyboard] Add Durgod Taurus K310 keyboard (qmk#12314)
  [Keyboard] Updated keyboard & keymaps (qmk#12667)
  [Keyboard] add SPRH keyboard (qmk#12999)
  Retain brightness with lighting layers (qmk#13025)
  [Keyboard] Add keypad Satxri6key (qmk#13423)
  [Keyboard] Initial Tron Guy Labs keyboard implementation. (qmk#13438)
  [Keyboard] Add Ristretto Keyboard (qmk#13479)
  [Keyboard] New Keyboard - OBE (qmk#13545)
  [Keyboard] Add personal planck keymap (qmk#13635)
  [Keymap] narze/xd004 (qmk#13634)
  [Keyboard] Add h0oni hotduck keyboard (qmk#13609)
  Fix API generation failure caused by GRS-70EC (qmk#13631)
  ...
@yiancar
Copy link
Contributor

yiancar commented Jul 23, 2021

No clue whats happening here :)
The idea is that the left part has the matrix for the "whole" keyboard. In my mind it is actually a "whole"keyboard if that makes sense. Just reports nothing for the other parts if they are not connected.

@skullydazed
Copy link
Member

No clue whats happening here :)

Data normalization, basically. :) We recently added a check to ensure that MATRIX_COLS is the same as the length of MATRIX_COL_PINS. In the case of this keyboard it isn't. I initially added NO_PIN (which seems to work everywhere else) to pad out the unused pins, but apparently that does not work here.

So now we're in a situation where it works but throws a warning, because the values don't match.

@skullydazed
Copy link
Member

I dug into this a bit more, I think something like this would fix it up at the cost of a few extra bytes: eab6f65

@Xelus22 Xelus22 deleted the dc01_left branch November 13, 2021 12:10
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Xelus22 @nhongooi
[Bug] Develop - DC01 left (qmk#13597)
a2477cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xelus22 @skullydazed @yiancar @drashna